Skip to content

Generate SDKs via pulumi package gen-sdk #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: vvm/bump_pu_pu_3.169.0
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented May 7, 2025

This PR removes the direct function calls into programgen for SDK generation in the bridge. Instead we now rely on the pulumi cli for this via pkg gen-sdk. This should produce no changes in the generated SDKs.

I've verified that AWS builds fine and has no SDK changes under this change. CI run here: pulumi/pulumi-aws#5512

fixes #1488

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 48.00000% with 52 lines in your changes missing coverage. Please review.

Project coverage is 68.68%. Comparing base (b36de3a) to head (780c721).

Files with missing lines Patch % Lines
pkg/tfgen/generate.go 48.00% 36 Missing and 16 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           vvm/bump_pu_pu_3.169.0    #3053      +/-   ##
==========================================================
+ Coverage                   68.59%   68.68%   +0.08%     
==========================================================
  Files                         335      335              
  Lines                       43415    43509      +94     
==========================================================
+ Hits                        29780    29883     +103     
+ Misses                      11956    11919      -37     
- Partials                     1679     1707      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VenelinMartinov VenelinMartinov changed the title wip [WIP] Generate SDKs via pulumi package gen-sdk May 8, 2025
@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch 3 times, most recently from 5fd1dc2 to 6d1ab38 Compare May 9, 2025 13:24
@VenelinMartinov VenelinMartinov changed the base branch from main to vvm/bump_pu_pu_3.169.0 May 9, 2025 15:59
@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented May 9, 2025

This change is part of the following stack:

Change managed by git-spice.

@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch from bc5993a to 0987bae Compare May 9, 2025 15:59
@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch 3 times, most recently from 3542a52 to 62e78e4 Compare May 9, 2025 16:40
@VenelinMartinov VenelinMartinov force-pushed the vvm/gen_sdk_generation branch from 62e78e4 to 780c721 Compare May 9, 2025 16:52
@VenelinMartinov VenelinMartinov requested review from t0yv0 and a team May 9, 2025 17:10
@VenelinMartinov VenelinMartinov marked this pull request as ready for review May 9, 2025 17:10
@VenelinMartinov VenelinMartinov changed the title [WIP] Generate SDKs via pulumi package gen-sdk Generate SDKs via pulumi package gen-sdk May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoke SDK generation via pulumi package gen-sdk --language ${LANG}
1 participant