-
Notifications
You must be signed in to change notification settings - Fork 45
Generate SDKs via pulumi package gen-sdk
#3053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VenelinMartinov
wants to merge
10
commits into
vvm/bump_pu_pu_3.169.0
Choose a base branch
from
vvm/gen_sdk_generation
base: vvm/bump_pu_pu_3.169.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vvm/bump_pu_pu_3.169.0 #3053 +/- ##
==========================================================
+ Coverage 68.59% 68.68% +0.08%
==========================================================
Files 335 335
Lines 43415 43509 +94
==========================================================
+ Hits 29780 29883 +103
+ Misses 11956 11919 -37
- Partials 1679 1707 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5fd1dc2
to
6d1ab38
Compare
This change is part of the following stack: Change managed by git-spice. |
bc5993a
to
0987bae
Compare
3542a52
to
62e78e4
Compare
62e78e4
to
780c721
Compare
pulumi package gen-sdk
pulumi package gen-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the direct function calls into programgen for SDK generation in the bridge. Instead we now rely on the pulumi cli for this via
pkg gen-sdk
. This should produce no changes in the generated SDKs.I've verified that AWS builds fine and has no SDK changes under this change. CI run here: pulumi/pulumi-aws#5512
fixes #1488